Skip to content

Document astro preview --background - #14336

Merged
ArmandPhilippot merged 5 commits into
v7.2from
preview-background-docs
Aug 5, 2026
Merged

ArmandPhilippot merged 5 commits into
v7.2from
preview-background-docs

Conversation

@matthewp

@matthewp matthewp commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description (required)

Documents astro preview --background

References

For withastro/astro#17174

For Astro version 7.2.0

@astrobot-houston

astrobot-houston commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/build-with-ai.mdx Source changed, localizations will be marked as outdated.
en/reference/adapter-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content seems good to me, but I wonder if we could improve the format to avoid having almost identical content. In both files.

I left a few suggestions (draft) on how this could be structured for the CLI reference. I think we could apply something similar for the "Build with AI" page.

@ArmandPhilippot ArmandPhilippot added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Aug 4, 2026
@ArmandPhilippot ArmandPhilippot added this to the 7.2 milestone Aug 4, 2026
@matthewp
matthewp marked this pull request as ready for review August 4, 2026 17:11

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deduplication works; thanks for the update!

I was double-checking the implementation, and I noticed we also need to update PreviewServer as the PR adds urls. And we document the type, because it is useful for adapter authors to build a preview entrypoint.

After that, I think we're ready!

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a nit to add a link for adapter authors... but I noticed that the lock file is not mentioned anywhere other than in the "Building with AI" page. I know this is the first use case, but I think the reference should mention it as well. So, I left two suggestions.

Otherwise, LGTM! Thanks!

matthewp and others added 2 commits August 4, 2026 17:42
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@ArmandPhilippot

Copy link
Copy Markdown
Member

Thanks again! I'm updating the branch and merging this, so we have a single PR to merge for the 7.2 release.

@ArmandPhilippot
ArmandPhilippot changed the base branch from main to v7.2 August 5, 2026 21:18
@ArmandPhilippot
ArmandPhilippot merged commit deed0c8 into v7.2 Aug 5, 2026
9 checks passed
@ArmandPhilippot
ArmandPhilippot deleted the preview-background-docs branch August 5, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants