Repository navigation
Document astro preview --background - #14336
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Preview deployment ✅ Deployment complete!
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
The content seems good to me, but I wonder if we could improve the format to avoid having almost identical content. In both files.
I left a few suggestions (draft) on how this could be structured for the CLI reference. I think we could apply something similar for the "Build with AI" page.
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I think the deduplication works; thanks for the update!
I was double-checking the implementation, and I noticed we also need to update PreviewServer as the PR adds urls. And we document the type, because it is useful for adapter authors to build a preview entrypoint.
After that, I think we're ready!
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I had a nit to add a link for adapter authors... but I noticed that the lock file is not mentioned anywhere other than in the "Building with AI" page. I know this is the first use case, but I think the reference should mention it as well. So, I left two suggestions.
Otherwise, LGTM! Thanks!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Thanks again! I'm updating the branch and merging this, so we have a single PR to merge for the 7.2 release. |
Description (required)
Documents
astro preview --backgroundReferences
For withastro/astro#17174
For Astro version
7.2.0